fix: improve client validity checks#27
Merged
oylsister merged 3 commits intooylsister:mainfrom Nov 7, 2025
Merged
Conversation
- Gets rid of the `IsValidClient` function usage and instead uses the needed checks for each case in the plugin - Minor fixes regarding menu's callback's first param client validity check
Contributor
|
These changes was tested ? utilshelper still needed to be include? |
Contributor
Author
I didn't check if the plugin used any funciton other than |
Contributor
Author
|
The plugin still uses |
Owner
|
@Dolly132 build failed |
Contributor
Author
Should be good now |
Contributor
|
It was merged without any tests.. Will make some tests and make a new PR if fixes are needed.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsValidClientfunction usage and instead uses the needed checks for each case in the plugin